CubeBit/chat
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* fixing security issues by encryption

Browse Source 
Signed-off-by: CubeBit <denis-seredenko@ukr.net>
This commit is contained in:
Denys Seredenko
2023-08-03 17:42:57 +02:00
parent 3b03b2258a
commit 3b6d18a83b
8 changed files with 74 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/src/main/java/org/orinprojects/client/Client.java
View File

@@ -19,6 +19,8 @@ public class Client {
static SecretKey aesKey; static SecretKey aesKey;
static byte[] ivKey;
public static void main(String[] args) throws Exception { public static void main(String[] args) throws Exception {
Map<String, String> validatedArguments = getValidatedDataFromArguments(args); Map<String, String> validatedArguments = getValidatedDataFromArguments(args);
@@ -50,7 +52,7 @@ public class Client {
System.out.println("Wait for complete initialisation!"); System.out.println("Wait for complete initialisation!");
if (client.rsaReceived && client.aesReceived) { if (client.rsaReceived && client.aesReceived) {
String encryptedText = EncryptionUtil.encryptWithAES(inputText, aesKey); String encryptedText = EncryptionUtil.encryptWithAES(inputText, aesKey, ivKey);
client.out.println("TXT" + encryptedText); client.out.println("TXT" + encryptedText);
client.out.flush(); client.out.flush();
} }

11
client/src/main/java/org/orinprojects/client/ClientThread.java
View File

@@ -10,6 +10,7 @@ import java.io.IOException;
import java.io.InputStreamReader; import java.io.InputStreamReader;
import java.io.PrintWriter; import java.io.PrintWriter;
import java.net.Socket; import java.net.Socket;
import java.security.InvalidAlgorithmParameterException;
import java.security.InvalidKeyException; import java.security.InvalidKeyException;
import java.security.NoSuchAlgorithmException; import java.security.NoSuchAlgorithmException;
import java.security.spec.InvalidKeySpecException; import java.security.spec.InvalidKeySpecException;
@@ -53,12 +54,18 @@ public class ClientThread implements Runnable {
continue; continue;
} }
if (prefix.equals("IVK")) {
String decryptedIVKey = EncryptionUtil.decryptWithRSA(restMessage, Client.keys.getPrivate());
Client.ivKey = EncryptionUtil.ivKeyFromString(decryptedIVKey);
continue;
}
if (prefix.equals("TXT") && aesReceived && rsaReceived) { if (prefix.equals("TXT") && aesReceived && rsaReceived) {
String decryptedMessage = EncryptionUtil.decryptWithAES(restMessage, Client.aesKey); String decryptedMessage = EncryptionUtil.decryptWithAES(restMessage, Client.aesKey, Client.ivKey);
System.out.println(decryptedMessage); System.out.println(decryptedMessage);
} }
} catch (NoSuchPaddingException | IllegalBlockSizeException | IOException | NoSuchAlgorithmException | } catch (NoSuchPaddingException | IllegalBlockSizeException | IOException | NoSuchAlgorithmException |
InvalidKeySpecException | BadPaddingException | InvalidKeyException e) { InvalidKeySpecException | BadPaddingException | InvalidKeyException | InvalidAlgorithmParameterException e) {
System.out.println("Disconnected from server!"); System.out.println("Disconnected from server!");
System.exit(-1); System.exit(-1);
closeAllConnections(clientSocket, in, out); closeAllConnections(clientSocket, in, out);

5
desktop-client/src/main/java/org/orinprojects/desktop/ChatController.java
View File

@@ -16,6 +16,7 @@ import javax.crypto.IllegalBlockSizeException;
import javax.crypto.NoSuchPaddingException; import javax.crypto.NoSuchPaddingException;
import java.io.IOException; import java.io.IOException;
import java.net.Socket; import java.net.Socket;
import java.security.InvalidAlgorithmParameterException;
import java.security.InvalidKeyException; import java.security.InvalidKeyException;
import java.security.NoSuchAlgorithmException; import java.security.NoSuchAlgorithmException;
@@ -88,12 +89,12 @@ public class ChatController {
sendMsgBtn.setDisable(true); sendMsgBtn.setDisable(true);
} }
public void sendMessage() throws IllegalBlockSizeException, NoSuchPaddingException, BadPaddingException, NoSuchAlgorithmException, InvalidKeyException { public void sendMessage() throws IllegalBlockSizeException, NoSuchPaddingException, BadPaddingException, NoSuchAlgorithmException, InvalidKeyException, InvalidAlgorithmParameterException {
if (!clientThread.aesReceived && !clientThread.rsaReceived) if (!clientThread.aesReceived && !clientThread.rsaReceived)
System.out.println("Wait for complete initialisation!"); System.out.println("Wait for complete initialisation!");
if (clientThread.rsaReceived && clientThread.aesReceived) { if (clientThread.rsaReceived && clientThread.aesReceived) {
String encryptedText = EncryptionUtil.encryptWithAES(messageTextInput.getText(), aesKey); String encryptedText = EncryptionUtil.encryptWithAES(messageTextInput.getText(), aesKey, Main.ivKey);
clientThread.out.println("TXT" + encryptedText); clientThread.out.println("TXT" + encryptedText);
clientThread.out.flush(); clientThread.out.flush();
} }

11
desktop-client/src/main/java/org/orinprojects/desktop/ClientThread.java
View File

@@ -16,6 +16,7 @@ import java.io.IOException;
import java.io.InputStreamReader; import java.io.InputStreamReader;
import java.io.PrintWriter; import java.io.PrintWriter;
import java.net.Socket; import java.net.Socket;
import java.security.InvalidAlgorithmParameterException;
import java.security.InvalidKeyException; import java.security.InvalidKeyException;
import java.security.NoSuchAlgorithmException; import java.security.NoSuchAlgorithmException;
import java.security.spec.InvalidKeySpecException; import java.security.spec.InvalidKeySpecException;
@@ -65,8 +66,14 @@ public class ClientThread implements Runnable {
continue; continue;
} }
if (prefix.equals("IVK")) {
String decryptedIVKey = EncryptionUtil.decryptWithRSA(restMessage, Main.keys.getPrivate());
Main.ivKey = EncryptionUtil.ivKeyFromString(decryptedIVKey);
continue;
}
if (prefix.equals("TXT") && aesReceived && rsaReceived) { if (prefix.equals("TXT") && aesReceived && rsaReceived) {
String decryptedMessage = EncryptionUtil.decryptWithAES(restMessage, Main.aesKey); String decryptedMessage = EncryptionUtil.decryptWithAES(restMessage, Main.aesKey, Main.ivKey);
Label text = new Label(decryptedMessage); Label text = new Label(decryptedMessage);
text.setFont(new Font(14)); text.setFont(new Font(14));
@@ -75,7 +82,7 @@ public class ClientThread implements Runnable {
Platform.runLater(() -> messagesBox.getChildren().add(text)); Platform.runLater(() -> messagesBox.getChildren().add(text));
} }
} catch (NoSuchPaddingException | IllegalBlockSizeException | IOException | NoSuchAlgorithmException | } catch (NoSuchPaddingException | IllegalBlockSizeException | IOException | NoSuchAlgorithmException |
InvalidKeySpecException | BadPaddingException |InvalidKeyException e) { InvalidKeySpecException | BadPaddingException |InvalidKeyException | InvalidAlgorithmParameterException e) {
System.err.println("Disconnected from server!"); System.err.println("Disconnected from server!");
System.exit(-1); System.exit(-1);
closeAllConnections(clientSocket, in, out); closeAllConnections(clientSocket, in, out);

2
desktop-client/src/main/java/org/orinprojects/desktop/Main.java
View File

@@ -24,6 +24,8 @@ public class Main extends Application {
static SecretKey aesKey; static SecretKey aesKey;
static byte[] ivKey;
@Override @Override
public void start(Stage primaryStage) throws IOException, NoSuchAlgorithmException { public void start(Stage primaryStage) throws IOException, NoSuchAlgorithmException {
keys = EncryptionUtil.generateRSAKeys(); keys = EncryptionUtil.generateRSAKeys();

15
server/src/main/java/org/orinprojects/ClientHandler.java
View File

@@ -57,6 +57,11 @@ public class ClientHandler implements Runnable {
out.println("AES" + encryptedAES); out.println("AES" + encryptedAES);
out.flush(); out.flush();
String encodedIVKey = EncryptionUtil.ivKeyToString(Server.ivKey);
String encryptedIVKey = EncryptionUtil.encryptWithRSA(encodedIVKey, Server.clientKeys.get(username));
out.println("IVK" + encryptedIVKey);
out.flush();
aesSent = true; aesSent = true;
continue; continue;
} }
@@ -64,11 +69,11 @@ public class ClientHandler implements Runnable {
if (prefix.equals("WLC")) { if (prefix.equals("WLC")) {
this.username = restMessage; this.username = restMessage;
//TODO: add better logic //TODO: add better logic
if (Server.clientKeys.get(username) != null) { // if (Server.clientKeys.get(username) != null) {
in.close(); // in.close();
out.close(); // out.close();
clientSocket.close(); // clientSocket.close();
} // }
continue; continue;
} }

3
server/src/main/java/org/orinprojects/Server.java
View File

@@ -29,8 +29,11 @@ public class Server {
static SecretKey aesKey; static SecretKey aesKey;
static byte[] ivKey;
public static void main(String[] args) throws IOException, ArgumentsException, NoSuchAlgorithmException { public static void main(String[] args) throws IOException, ArgumentsException, NoSuchAlgorithmException {
Server.serverKeys = EncryptionUtil.generateRSAKeys(); Server.serverKeys = EncryptionUtil.generateRSAKeys();
Server.ivKey = EncryptionUtil.generateIV();
Server.aesKey = EncryptionUtil.generateAESKey(); Server.aesKey = EncryptionUtil.generateAESKey();
int portNumber = getPortNumber(args); int portNumber = getPortNumber(args);

42
server/src/main/java/org/orinprojects/encryption/EncryptionUtil.java
View File

@@ -1,6 +1,7 @@
package org.orinprojects.encryption; package org.orinprojects.encryption;
import javax.crypto.*; import javax.crypto.*;
import javax.crypto.spec.GCMParameterSpec;
import javax.crypto.spec.SecretKeySpec; import javax.crypto.spec.SecretKeySpec;
import java.security.*; import java.security.*;
import java.security.spec.InvalidKeySpecException; import java.security.spec.InvalidKeySpecException;
@@ -10,10 +11,14 @@ import java.util.Base64;
public class EncryptionUtil { public class EncryptionUtil {
public static final int RSA_KEY_SIZE = 2048; public static final int RSA_KEY_SIZE = 4096;
public static final int AES_KEY_SIZE = 256; public static final int AES_KEY_SIZE = 256;
public static final int GCM_IV_LENGTH = 12;
public static final int GCM_TAG_LENGTH = 16;
private EncryptionUtil() throws IllegalAccessException { private EncryptionUtil() throws IllegalAccessException {
throw new IllegalAccessException("Can't be instantiated"); throw new IllegalAccessException("Can't be instantiated");
} }
@@ -73,18 +78,34 @@ public class EncryptionUtil {
return keyGenerator.generateKey(); return keyGenerator.generateKey();
} }
public static String encryptWithAES(String plainText, SecretKey aesKey) throws IllegalBlockSizeException, BadPaddingException, NoSuchPaddingException, NoSuchAlgorithmException, InvalidKeyException { public static byte[] generateIV() {
Cipher aesChiper = Cipher.getInstance("AES"); byte[] iv = new byte[GCM_IV_LENGTH];
aesChiper.init(Cipher.ENCRYPT_MODE, aesKey); SecureRandom random = new SecureRandom();
random.nextBytes(iv);
return iv;
}
public static String encryptWithAES(String plainText, SecretKey aesKey, byte[] ivKey) throws IllegalBlockSizeException, BadPaddingException, NoSuchPaddingException, NoSuchAlgorithmException, InvalidKeyException, InvalidAlgorithmParameterException {
Cipher aesChiper = Cipher.getInstance("AES/GCM/NoPadding");
SecretKeySpec keySpec = new SecretKeySpec(aesKey.getEncoded(), "AES");
GCMParameterSpec gcmParameterSpec = new GCMParameterSpec(GCM_TAG_LENGTH * 8, ivKey);
aesChiper.init(Cipher.ENCRYPT_MODE, keySpec, gcmParameterSpec);
byte[] byteCipherText = aesChiper.doFinal(plainText.getBytes()); byte[] byteCipherText = aesChiper.doFinal(plainText.getBytes());
return Base64.getEncoder().encodeToString(byteCipherText); return Base64.getEncoder().encodeToString(byteCipherText);
} }
public static String decryptWithAES(String encryptedMessage, SecretKey aesKey) throws IllegalBlockSizeException, BadPaddingException, NoSuchPaddingException, NoSuchAlgorithmException, InvalidKeyException { public static String decryptWithAES(String encryptedMessage, SecretKey aesKey, byte[] ivKey) throws IllegalBlockSizeException, BadPaddingException, NoSuchPaddingException, NoSuchAlgorithmException, InvalidKeyException, InvalidAlgorithmParameterException {
Cipher aesChiper = Cipher.getInstance("AES"); Cipher aesChiper = Cipher.getInstance("AES/GCM/NoPadding");
aesChiper.init(Cipher.DECRYPT_MODE, aesKey);
SecretKeySpec keySpec = new SecretKeySpec(aesKey.getEncoded(), "AES");
GCMParameterSpec gcmParameterSpec = new GCMParameterSpec(GCM_TAG_LENGTH * 8, ivKey);
aesChiper.init(Cipher.DECRYPT_MODE, keySpec, gcmParameterSpec);
byte[] byteCipherText = aesChiper.doFinal(Base64.getDecoder().decode(encryptedMessage)); byte[] byteCipherText = aesChiper.doFinal(Base64.getDecoder().decode(encryptedMessage));
@@ -100,4 +121,11 @@ public class EncryptionUtil {
return Base64.getEncoder().encodeToString(secretKey.getEncoded()); return Base64.getEncoder().encodeToString(secretKey.getEncoded());
} }
public static String ivKeyToString(byte[] iv) {
return Base64.getEncoder().encodeToString(iv);
}
public static byte[] ivKeyFromString(String ivKey) {
return Base64.getDecoder().decode(ivKey);
}
} }